search

cloudfoundry-community / node-cfenv

easy access to your Cloud Foundry application environment for node
Apache License 2.0
73 stars 20 forks source link

getServiceURL break url #21

Closed melnikaite closed 7 years ago

melnikaite commented 7 years ago

console.log(appEnv.getServiceURL('mongodb-instance'));

console.log(appEnv.getService('mongodb-instance').credentials.uri);

mongodb://admin:XXX@sl-us-dal-9-portal.4.dblayer.com:18394/:18394,sl-us-dal-9-portal.1.dblayer.com/admin?ssl=true

mongodb://admin:XXX@sl-us-dal-9-portal.4.dblayer.com:18394,sl-us-dal-9-portal.1.dblayer.com:18394/admin?ssl=true

pmuellr commented 7 years ago

Ah, yikes! smells like url.parse() shenanigans, since I just ran into something very similar in a different set of code.

Thanks for reporting!

melnikaite commented 7 years ago

It'd be nice to have this fix in 1.0.4. Are there any plans to make new release?

pmuellr commented 7 years ago

@melnikaite sorry, was waiting for a review in the 1.0.4 PR https://github.com/cloudfoundry-community/node-cfenv/pull/23 . Ping'd reviewer again, will update tomorrow if I haven't heard back.

pmuellr commented 7 years ago

@melnikaite there's now a fresh 1.0.4 up on npm