search

cloudfoundry-community / node-cfenv

easy access to your Cloud Foundry application environment for node
Apache License 2.0
73 stars 20 forks source link

updates for version 1.0.4 #23

Closed pmuellr closed 7 years ago

pmuellr commented 7 years ago

@srl295 Should probably be in the habit of having someone review version updates - could you take a look?

Should have also had you look at the PR that makes up the functional change for this version - PR https://github.com/cloudfoundry-community/node-cfenv/pull/22 - could you peek at that as well?

I'll update npm after merging this.

pmuellr commented 7 years ago

@srl295 did you get a chance to review this? Specifically the PR referenced in the initial comment.

pmuellr commented 7 years ago

went ahead and merged this and then published to npm as 1.0.4

srl295 commented 7 years ago

sorry, i did not see this at all until the 'went ahead and merged' :(

srl295 commented 7 years ago

after the fact LGTM