cloudfoundry-community / node-cfenv

easy access to your Cloud Foundry application environment for node
Apache License 2.0
73 stars 20 forks source link

Locally use the options to read the port #36

Closed smg-bg closed 5 years ago

smg-bg commented 5 years ago

We were trying to use the library with providing the vcapFile, but whenever we change the application port it's not reflected in the returned port.

It's a really simple fix, but we would want to hear your opinion and if possible to merge it back.

pmuellr commented 5 years ago

Sorry for the delay in responding, somehow I missed seeing this.

This fix seems reasonable to me. I'll try it out and merge in a bit ...

pmuellr commented 5 years ago

I've merged this into master, and it's now available in cfenv 1.2.0 on npm.

Thanks so much for your contribution, and again, sorry for the delay!