search

cloudfoundry-community / node-cfenv

easy access to your Cloud Foundry application environment for node
Apache License 2.0
73 stars 20 forks source link

Upgrade underscore version 1.9.x #37

Closed jonnynabors closed 5 years ago

jonnynabors commented 5 years ago

Ran into the following error when behind a corporate firewall and adding cfenv to a project from npm:

An unexpected error occurred: "http://registry.npmjs.org/underscore/-/underscore-1.8.3.tgz: Request failed \"403 Forbidden\"".

We tested adding underscore 1.8.3 by itself to our project and got the same error as above. Adding underscore 1.9.x worked fine, so our assumption is that upgrading underscore to 1.9.x will resolve this problem for cfenv for users behind a corporate firewall.

pmuellr commented 5 years ago

Sorry for the delay in responding, somehow this dropped off my radar.

Did you ever find out why you were getting a 403 from the underscore tarball? I just tried here and it works fine. I can't imagine why getting the 1.8.x tarball would be blocked by your firewall, but a 1.9.x one wouldn't.

I checked to see if there was a vulnerability against underscore from snyk.io - didn't see anything. Sometimes customers run software that blocks vulnerable versions from being downloaded.

There's no real harm in upgrading either, so will merge shortly.

pmuellr commented 5 years ago

I've merged this into master, and it's now available in cfenv 1.2.0 on npm.

Thanks so much for your contribution, and again, sorry for the delay!