search

cloudfoundry-community / slack-notification-resource

Concourse CI resource for sending notifications to Slack.
MIT License
75 stars 82 forks source link

Adding set +x to prevent slack hook endpoint from being exposed #13

Closed ForestEckhardt closed 7 years ago

ForestEckhardt commented 8 years ago

Not sure if this is the right solution, but we shouldn't be exposing webhook, which allows any users to post on a channel.

Thoughts?

Signed-off-by: Forest Eckhardt forest.eckhardt@gmail.com

o-orand commented 7 years ago

@ForestEckhardt I think it's already possible with silent option. silent: Optional. Do not print curl output (avoids leaking slack webhook URL). Maybe we should enable it by default. Seems related to #12

lnguyen commented 7 years ago

Thanks