search

cloudfoundry-community / slack-notification-resource

Concourse CI resource for sending notifications to Slack.
MIT License
75 stars 82 forks source link

added linked_name option for the post body #48

Closed pontusarfwedson closed 6 years ago

pontusarfwedson commented 6 years ago

PR to add functionality for the user to use link_names in slack notification. This gives the user possibility to ping user groups etc which otherwise is impossible.

drnic commented 6 years ago

Thanks!

drnic commented 6 years ago

@pontusarfwedson I merged this because it looked harmless at a glance; unfortunately it broke the CI pipeline. https://ci.starkandwayne.com/teams/main/pipelines/slack-notification-resource/jobs/build/builds/40

I've revert it on master. I'm sorry but can I ask you to create the PR again, and confirm that docker build -t cfcommunity/slack-notification-resource . runs ok first? Thanks!

pontusarfwedson commented 6 years ago

Hey! Yes, did a poor job with testing, will do that! /Pontus

ons 21 mars 2018 kl. 03:41 skrev Dr Nic Williams notifications@github.com:

@pontusarfwedson https://github.com/pontusarfwedson I merged this because it looked harmless at a glance; unfortunately it might have broken the CI pipeline. I've revert it on master. I'm sorry but can I ask you to create the PR again, and confirm that docker build -t cfcommunity/slack-notification-resource . runs ok first? Thanks!

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/cloudfoundry-community/slack-notification-resource/pull/48#issuecomment-374819662, or mute the thread https://github.com/notifications/unsubscribe-auth/AHiNIpfme2bUwjHMrdV88PfvL-FXxG5eks5tgb3agaJpZM4SyJVc .

pontusarfwedson commented 6 years ago

Hey Dr Nic Williams! I think the initial issue was that I actually forgot a comma in the build of the json. So that made the json unparseable. However, when fixed that I still have a hard time making the tests pass. Cannot really seem to figure out how you've constructed the tests, doesn't seem to easy to adapt them. Any input?

2018-03-21 3:31 GMT+01:00 Dr Nic Williams notifications@github.com:

Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cloudfoundry-community/slack-notification-resource/pull/48#issuecomment-374818391, or mute the thread https://github.com/notifications/unsubscribe-auth/AHiNInP3K2z3jNHv4XdKyWUAIge7A9Tsks5tgbtogaJpZM4SyJVc .