search

cloudfoundry-community / slack-notification-resource

Concourse CI resource for sending notifications to Slack.
MIT License
75 stars 82 forks source link

Fixes printf for text #6

Closed bsnchan closed 8 years ago

bsnchan commented 8 years ago

We are wrapping the multiline text with a quote so that the entire multiline text is printed instead of just the first line.

For example, wrapping a multiline text without quotes throws the following error:

eval "printf this is line 1
> this is line 2
> this is line 3"
thisbash: this: command not found
bash: this: command not found

Wrapping the multiline text with quote will print successfully:

eval "printf 'this is line 1
this is line 2
this is line 3'"
this is line 1
this is line 2
this is line 3

@drnic @longnguyen11288 : when we get this merged, can we create a new bosh release with the updated resource as well please?

_update: _ Noticed that this is actually failing for strings with spaces as well.

bsnchan commented 8 years ago

@longnguyen11288 It looks like the pipeline to package it into the bosh release may have failed: https://ci.starkandwayne.com/pipelines/slack-notification-resource-boshrelease/jobs/embed/builds/18

lnguyen commented 8 years ago

yeah i upgraded concourse... and it broke pipeline... and havent had chance to look at it. let me put it on older version of concourse and cut a release for you.

On Feb 9 2016, at 2:13 pm, Brenda Chan <notifications@github.com> wrote:

@longnguyen11288 It looks like the pipeline to package it into the bosh release may have failed: https://ci.starkandwayne.com/pipelines/slack-notification-resource- boshrelease/jobs/embed/builds/18

—
Reply to this email directly or view it on GitHub.

lnguyen commented 8 years ago

done new release cut

On Feb 9 2016, at 3:05 pm, Long Nguyen <long.nguyen11288@gmail.com> wrote:
yeah i upgraded concourse... and it broke pipeline... and havent had chance to look at it. let me put it on older version of concourse and cut a release for you.

On Feb 9 2016, at 2:13 pm, Brenda Chan <notifications@github.com> wrote:

@longnguyen11288 It looks like the pipeline to package it into the bosh release may have failed: https://ci.starkandwayne.com/pipelines/slack-notification-resource- boshrelease/jobs/embed/builds/18

—
Reply to this email directly or view it on GitHub.