cloudfoundry-community / slack-notification-resource

Concourse CI resource for sending notifications to Slack.
MIT License
75 stars 81 forks source link

adding fix for mattermost compatibility #77

Closed pjaudiomv closed 4 years ago

pjaudiomv commented 4 years ago

I know this is a slack notifier but this PR would fix compatibility with mattermost which is almost fully compatible with Slack API. Except it doesn't accept link_names as it does this automatically. This should pretty much be a no op, I have tested and all tests pass. Referencing PR where link_names was added https://github.com/cloudfoundry-community/slack-notification-resource/pull/51

jhunt commented 4 years ago

Thanks!

dgershman commented 4 years ago

This is an amazing contribution @pjaudiomv ! Thank you for this!!! This was a concrete galosh before this change.

jbraswell commented 4 years ago

Good show