cloudfoundry-community / slack-notification-resource

Concourse CI resource for sending notifications to Slack.

MIT License

75 stars 81 forks source link

Slack channel name #85

Open professor opened 4 years ago

professor commented 4 years ago

Slack currently creates a webhook per channel. The API for this concourse resource implies that you can change the slack channel name without changing the webhook. Unfortunately, changing the channel name in yml won't work...

---
jobs:
- name: some-job
  plan:
  - put: slack-alert
    params:
      channel: '#my_channel'

my_channel needs to be the match the webhook url

jhunt commented 4 years ago

Yeah, we need to remove the channel param altogether, since they don't do it that way any more.

jhunt commented 4 years ago

I put in https://github.com/cloudfoundry-community/slack-notification-resource/pull/86 for this. Would you care to take it for a spin?

professor commented 3 years ago

@jhunt -- what's the best mechanism for me to test #86? Is there a tag for it?

jhunt commented 3 years ago

No, but you should be able to build the image off of the branch and push it to DockerHub to test locally.