search

cloudfoundry-community / slack-notification-resource

Concourse CI resource for sending notifications to Slack.
MIT License
75 stars 81 forks source link

Require image for ARM64 architecture #90

Open odidev opened 3 years ago

odidev commented 3 years ago

Hi Team,

I am trying to use slack-notification-resource on ARM64 architecture but it seems ARM64 tag is not available in Docker Hub for the same.

I have successfully built the arm64 image using command docker build -t image_name . in my ARM64 local machine.

I have added below changes in MAKEFILE:

  1. I have used buildx to build and push the image for both platforms.
  2. Added install tag to install buildx binary and created a new builder and switched to it.

Commit: https://github.com/odidev/slack-notification-resource/commit/d1ffe2c99f4306c109f70f64471bcad1a495d430

I have added the above changes and uploaded this image to my account using make VERSION=x.y.z release command.

ARM64 Image: https://hub.docker.com/repository/docker/odidev/slack-notification-resource

It will be very helpful if the image is released with ARM64 support. If interested, I will raise a PR with the above changes.

jhunt commented 3 years ago

We should probably just put these images under the control of either Dockerhubs build service or GitHub actions.

Sent from my iPhone

On Dec 15, 2020, at 2:07 AM, odidev notifications@github.com wrote:

 Hi Team,

I am trying to use slack-notification-resource on ARM64 architecture but it seems ARM64 tag is not available in Docker Hub for the same.

I have successfully built the arm64 image using command docker build -t image_name . in my ARM64 local machine.

I have added below changes in MAKEFILE:

  1. I have used buildx to build and push the image for both platforms.
  2. Added install tag to install buildx binary and created a new builder and switched to it.

Commit: odidev@d1ffe2c

I have added the above changes and uploaded this image to my account using make VERSION=x.y.z release command.

ARM64 Image: https://hub.docker.com/repository/docker/odidev/slack-notification-resource

It will be very helpful if the image is released with ARM64 support. If interested, I will raise a PR with the above changes.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.