search

cloudfoundry-community / slack-notification-resource

Concourse CI resource for sending notifications to Slack.
MIT License
75 stars 81 forks source link

Interpolate the content of `text file` #99

Closed bgandon closed 5 months ago

bgandon commented 5 months ago

With this PR, the content of text_file is interpolated the same way text is.

The change in out is quite trivial, and we've added two automated tests to cover the new expected behavior.

This new behavior may produce unexpected results when the content of the text_file includes some environment variables that are to be printed verbatim and not expanded.

We think that including variables like $BUILD_PIPELINE_NAME in the ù text_file` and expecting these to be printed verbatim in a Slack message is a very uncommon requirement. Thus, we expect the impact to be very limited.

bgandon commented 5 months ago

PR-testing pipeline job is broken but the build and tests are passing ✅