cloudfoundry-community / splunk-firehose-nozzle

Send CF component metrics, CF app logs, and CF app metrics to Splunk
Apache License 2.0
29 stars 29 forks source link

Update Go version and migrate to Go modules #287

Closed kashyap-splunk closed 3 years ago

kashyap-splunk commented 3 years ago

Includes below changes:

Let me know if I missed anything

luckyj5 commented 3 years ago

Do we need the vendor folder?

kashyap-splunk commented 3 years ago

Do we need the vendor folder?

Vendor folder can help building without network access or having faster builds, both during development and in CI/CD pipelines. But we can remove it if this was not the original intention of keeping the vendor folder earlier.

luckyj5 commented 3 years ago

Do we need the vendor folder?

Vendor folder can help building without network access or having faster builds, both during development and in CI/CD pipelines. But we can remove it if this was not the original intention of keeping the vendor folder earlier.

Yeah, the original intent was to be able to run it when restrictive network access. I was thinking of cleaning it up here since it anyways will be packaged in the tile. For now, let's leave it. Thanks!