cloudfoundry-community / splunk-firehose-nozzle

Send CF component metrics, CF app logs, and CF app metrics to Splunk
Apache License 2.0
28 stars 29 forks source link

Refactoring sonarqube issues #355

Closed sbylica-splunk closed 9 months ago

sbylica-splunk commented 9 months ago

PR fixes most of the issues raised by sonarqube

VihasMakwana commented 9 months ago

LGTM! Will approve it once we get pipeline green and our PCF env running.

sbylica-splunk commented 9 months ago

LGTM! Will approve it once we get pipeline green and our PCF env running.

Pipeline is working and we finished our 1.3.0 merge, so I think this one is good to go :)