make cf routes hyperlinks use https instead of http - Githubissues

cloudfoundry-community / stratos

Stratos: Web-based Management UI for Cloud Foundry and Kubernetes

MIT License

2 stars 7 forks source link

make cf routes hyperlinks use https instead of http #33

Open metskem opened 3 months ago

metskem commented 3 months ago

make cf routes hyperlinks use https instead of http

Description

The current list of routes (Applications => => Routes ), have hyperlinks using http, I think we should make these https.

Motivation and Context

Using https is the default nowadays.

How Has This Been Tested?

This has been running for about a year in all our CF environments, where we used our own fork of Stratos (github.com/rabobank/stratos).

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Docs update
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x ] Change behaviour, make it more secure

Checklist:

[ x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ x] I have followed the guidelines in CONTRIBUTING.md, including the required formatting of the commit message

norman-abramovitz commented 3 months ago

The coding looks good and I agree with the premise, but this change would need to be a breaking change since it is changing the route to use https:// instead of http://. I am wondering if we can parameterize the default setting.