cloudfoundry-community / terraform-provider-cloudfoundry

Terraform Cloud Foundry Provider
https://registry.terraform.io/providers/cloudfoundry-community/cloudfoundry/latest
Mozilla Public License 2.0
73 stars 87 forks source link

Setting healthcheck invocation timeout #306

Open sleungcy opened 3 years ago

sleungcy commented 3 years ago

Is there a way I can define the healthcheck invocation timeout for my application? healthcheck invocation timeout is different from healthcheck-timeout, the invocation timeout is a timeout for each invocation of the healthcheck endpoint, while the healthcheck-timeout is an overall encompassing limit of all the retries combined.

loafoe commented 3 years ago

The v3 API supports this, example:

https://github.com/cloudfoundry-community/cloudfoundry-cli/blob/d6a4525baeca819ac1d1b69d36f86f648d2fd9b3/api/cloudcontroller/ccv3/process.go#L155-L162

adding support for this while still primarily using the v2 would be the challenge

DavidMichonneau commented 1 year ago

is this supported yet in the latest version?

loafoe commented 1 year ago

This has not been implemented yet, but should be much easier to add now that the switch to v3 has been done

DavidMichonneau commented 1 year ago

The documentation seems to indicate it is available though? https://github.com/cloudfoundry-community/terraform-provider-cloudfoundry/blob/main/docs/resources/app.md

loafoe commented 1 year ago

@DavidMichonneau ah looks like it was added indeed. This means it should be the latest release. If you can try and verify we can close this one.

andersonvcv commented 2 months ago

It worked fine when creating a new app from scratch, the health_check_invocation_timeout was correctly set to a value (10s), but for an existing app although the plan and apply finishes without errors I always see the following update.

Terraform will perform the following actions:

  module.app_service.cloudfoundry_app.app will be updated in-place
  ~ resource "cloudfoundry_app" "app" {
      ~ health_check_invocation_timeout = 0 -> 10
    }