cloudfoundry-community / terraform-provider-cloudfoundry

Terraform Cloud Foundry Provider
https://registry.terraform.io/providers/cloudfoundry-community/cloudfoundry/latest
Mozilla Public License 2.0
75 stars 87 forks source link

Update cf service instance test go for metadata label #543

Closed Jess713 closed 9 months ago

Jess713 commented 10 months ago

This enables using Metadata label feature in Terraform Example)

resource "cf_service_instance" "my-cloud" {
  name                  = "${var.service_name}-my-cloud"
  space                 = var.cf_space_id
  service_plan      = data.cf_service.hana-cloud.service_plans["mycloud"]
  labels = {
    instance-name = "${var.service_name}-my-cloud"
    instance-type = "my-cloud"
  }
sleungcy commented 10 months ago

We should update the wiki page as well https://github.com/cloudfoundry-community/terraform-provider-cloudfoundry/wiki/resource_service_instance

Also wondering if we have implementation for the annotation or just the label only?

Jess713 commented 10 months ago

hey Sam I only implemented for label only. Should we do the annotation too? I'll take a look at the wiki !

On Wed, Jan 17, 2024 at 1:39 PM Sam Leung @.***> wrote:

We should update the wiki page as well

https://github.com/cloudfoundry-community/terraform-provider-cloudfoundry/wiki/resource_service_instance

Also wondering if we have implementation for the annotation or just the label only?

— Reply to this email directly, view it on GitHub https://github.com/cloudfoundry-community/terraform-provider-cloudfoundry/pull/543#issuecomment-1896881264, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGEGL2I4E3RIUCG37Q3MZNTYPBAITAVCNFSM6AAAAABBZVAHO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJWHA4DCMRWGQ . You are receiving this because you authored the thread.Message ID: <cloudfoundry-community/terraform-provider-cloudfoundry/pull/543/c1896881264 @github.com>

loafoe commented 9 months ago

@Jess713 can you check the golint remarks? thx!

loafoe commented 9 months ago

@Jess713 thanks 🚀 Can you please update documentation in docs/resources/service_instance.md to describe the new labels argument. Should be good to merge then.

Jess713 commented 9 months ago

Hi @loafoe , I updated service_instance.md . please review. Thanks!