search

cloudfoundry-community / terraform-provider-cloudfoundry

Terraform Cloud Foundry Provider
https://registry.terraform.io/providers/cloudfoundry-community/cloudfoundry/latest
Mozilla Public License 2.0
75 stars 87 forks source link

Added create and delete timeouts for cloudfoundry_service_key resource #556

Closed srba-sap closed 8 months ago

srba-sap commented 8 months ago

The defaults are not changed from the initial implementation (60 seconds for both).

Generally, service key creation should not take more than a minute, but, if the service needs to execute complex operations, as, part of the key creation, this can take longer.

srba-sap commented 8 months ago

@loafoe and @sleungcy please, review

srba-sap commented 8 months ago

@sleungcy I have implemented what you have suggested, please, review.

sleungcy commented 8 months ago

@srba-sap could you add a testcase for this?

srba-sap commented 8 months ago

@sleungcy the UTs were already there (https://github.com/cloudfoundry-community/terraform-provider-cloudfoundry/blob/main/cloudfoundry/resource_cf_service_key_test.go) - I just added the new timeouts to the test setup.

sleungcy commented 8 months ago

I ran the test case and it worked. lgtm. I am not a maintainer, so need @loafoe to merge.