cloudfoundry-community / windows-stemcell-concourse

Provides tasks to take a Windows ISO and transform to a Windows stemcell for Cloud Foundry, in VSphere.
MIT License
13 stars 6 forks source link

Multiple YAML files have duplicate entries #42

Closed jak74 closed 3 months ago

jak74 commented 4 years ago

The vmware_tools_status and timeout entries are duplicated in clone-base.yml (lines 24-25 and 27-28). This causes issues with newer releases of yq:

failed to create task config from bytes pipeline-resources/tasks/clone-base.yml: error converting YAML to JSON: yams: unmarshal errors: line 27: key "vmware_tools_status" already set in map line 28: key "timeout" already set in map

The same is true of construct.yml, package.yml, and update-base.yml as well (in addition to clone-base.yml).

sneal commented 3 months ago

Looks like these were fixed in various PRs #47 #48 #50