search

cloudfoundry-incubator / admin-ui

Need new main contributor - An application for viewing Cloud Foundry metrics and operations data.
Apache License 2.0
71 stars 44 forks source link

Squash commits for i18n from PR #96 #128

Closed allomov closed 9 years ago

allomov commented 9 years ago

Squashed commits for i18n from PR #96

cfdreddbot commented 9 years ago

Hey allomov!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

allomov commented 9 years ago

thank you @cfdreddbot :)

rboykin commented 9 years ago

Thanks. I will look into it after the Thanksgiving break. Meaning not until December

rboykin commented 9 years ago

I ran this locally in my environment using Firefox on both Windows and Linux and have the following comments which preclude me from merging this PR:

  1. The language menu is not vertically aligned with the user menu
  2. The user menu is partially not shown. It is truncated.
  3. A change of language corrupts the currently-shown table. It needs a refresh
  4. The translation is not up-to-date with the current admin ui. Table columns are missing translation
  5. The field names inside the details sections are not translated
  6. You should use the .min.js version of i18next for download performance
  7. i18n.js should follow consistent JavaScript formatting and style with the rest of the Admin UI
  8. No new rspec tests were included for the language menu
  9. .gitignore update not needed
  10. .ruby-version update not needed
  11. Gemfile and Gemfile.lock changes no longer needed due to my recent commits.
allomov commented 9 years ago

Thank you for comments. Will take care about this changes.

On Tue, Dec 2, 2014 at 6:10 PM, J Russell Boykin notifications@github.com wrote:

I ran this locally in my environment using Firefox on both Windows and Linux and have the following comments which preclude me from merging this PR:

  1. The language menu is not vertically aligned with the user menu
  2. The user menu is partially not shown. It is truncated.
  3. A change of language corrupts the currently-shown table. It needs a refresh
  4. The translation is not up-to-date with the current admin ui. Table columns are missing translation
  5. The field names inside the details sections are not translated
  6. You should use the .min.js version of i18next for download performance
  7. i18n.js should follow consistent JavaScript formatting and style with the rest of the Admin UI
  8. No new rspec tests were included for the language menu
  9. .gitignore update not needed
  10. .ruby-version update not needed

11. Gemfile and Gemfile.lock changes no longer needed due to my recent commits.

Reply to this email directly or view it on GitHub: https://github.com/cloudfoundry-incubator/admin-ui/pull/128#issuecomment-65244584

rboykin commented 9 years ago

Closing this PR due to inactivity