Expose cookie settings.

cloudfoundry-incubator / admin-ui

Need new main contributor - An application for viewing Cloud Foundry metrics and operations data.

Apache License 2.0

71 stars 44 forks source link

Expose cookie settings. #182

Closed jmcarp closed 6 years ago

jmcarp commented 6 years ago

Cookie encryption secret should always be set; future versions of rack will require it.
Allow users to turn on secure cookies without terminating tls in the app.

cc @LinuxBozo

cfdreddbot commented 6 years ago

Hey jmcarp!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

rboykin commented 6 years ago

Manually merged with the following additions:

admin.rb requires latent load of web.rb to enable config global variables to be available upon web.rb class load
Config cookie_secret needs static accessor to enable access by configure blocks of web.rb and secure_web.rb
Config cookie_secret needs default to allow existing installations to function without change
Reorder new config values alphabetically
Add unit testing for new config values
Add to README.md for new config values