search

cloudfoundry-incubator / eirinix

Extensions Library for Cloud Foundry Eirini
Apache License 2.0
2 stars 5 forks source link

Respect RegisterWebHook also when generating configuration #13

Closed mudler closed 5 years ago

mudler commented 5 years ago

This was the last piece to limit the responsability of the code parts.

In this way extensions could be split in two binaries, one that creates the MutatingWebhookConfiguration (which can be a job, or just a process that later on drop capabilities) and one that runs the service in a no-cluster-admin context.

codecov[bot] commented 5 years ago

Codecov Report

Merging #13 into master will increase coverage by 0.06%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   70.71%   70.78%   +0.06%     
==========================================
  Files           3        3              
  Lines         420      421       +1     
==========================================
+ Hits          297      298       +1     
  Misses         99       99              
  Partials       24       24
Impacted Files Coverage Δ
manager.go 62.43% <33.33%> (+0.19%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d9705e1...18bdaee. Read the comment docs.