cloudfoundry-incubator / eirinix

Extensions Library for Cloud Foundry Eirini
Apache License 2.0
2 stars 5 forks source link

Consume latest RetryWatchers fixes #23

Closed mudler closed 4 years ago

mudler commented 4 years ago

https://github.com/kubernetes/client-go/commit/33c1f9f2a43292d0b2dcb00f435bf3becad0528d#diff-b414e368c7101665eb44ed4a6cba77ef treats an issue that potentially lead to https://github.com/SUSE/eirini-loggregator-bridge/issues/6 in certain circumstances. Definitely will make the Watcher implementation more robust behind the scenes.

Currently we cannot bump kubernetes/client-go and the controller-runtime as EiriniX depends on certain areas of code on the cf-operator, which makes those two library to be pinned at the cf-operator version.

We need either to find a way to be able to pin independently the dependencies, or vendor (if possible) the code needed. We could also track down the code shared with the cf-operator and make it shared in a different golang package.

mudler commented 4 years ago

31 is fixing the issue, it bumps all the dependencies to latest (and kubernetes/client-go to release-14.0 which includes the commit needed)