search

cloudfoundry-incubator / fissile

Turn a BOSH release into container images / files
Apache License 2.0
67 stars 36 forks source link

diff: dig into underlying types when stringifying #453

Closed mook-as closed 5 years ago

mook-as commented 5 years ago

When doing a fissile diff, we rely on the stringification of the specs to be consistent. However, when we have nested things (hashes-in-arrays and that kind of things), we end up getting an object of type Interface instead of the underlying type. Explicitly unwrap it to ensure we get the correct results.

The test cases have been updated to attempt to catch this case; however it is inherently random, so this may occasionally pass even when wrong.

The first commit renames the test data to make it easier to deal with, and has no actual change.

cfdreddbot commented 5 years ago

:white_check_mark: Hey mook-as! The commit authors and yourself have already signed the CLA.