search

cloudfoundry-incubator / fissile

Turn a BOSH release into container images / files
Apache License 2.0
67 stars 36 forks source link

Add fissile and stemcell version to the release image tags #471

Closed aduffeck closed 5 years ago

cfdreddbot commented 5 years ago

:white_check_mark: Hey aduffeck! The commit authors and yourself have already signed the CLA.

aduffeck commented 5 years ago

@jandubois With this change fissile depends on the new stemcells for calculating the release image tag which include labels for the stemcell flavor and version. The stemcell you used supposedly doesn't have these labels yet.

I'll improve the error reporting for such cases tomorrow, though.

aduffeck commented 5 years ago

As per a discussion with @viovanov we'll show a warning and resort to unknown-<image-id> instead of erroring out when the stemcell image doesn't have the labels.

jandubois commented 5 years ago

@aduffeck PRs should include a reference to the tracker id, so that bots can add a reference automatically.

[#163916819]

jandubois commented 5 years ago

Hmm, I guess it only works in the main description field, or in the commit messages...

aduffeck commented 5 years ago

@jandubois Yes, tracker is really picky about the format and the location of the reference. iirc only the pr description worked when we played around with it. I didn't put a reference here because I thought that the fissile repo wasn't connected to the cfcontainerization tracker, but maybe I'm mistaken. I'll give it a try next time.

jandubois commented 5 years ago

I didn't put a reference here because I thought that the fissile repo wasn't connected to the cfcontainerization tracker

@aduffeck It does seem to be hooked up; here is an auto-added commit reference: https://www.pivotaltracker.com/n/projects/2192232/stories/163013866