search

cloudfoundry-incubator / fissile

Turn a BOSH release into container images / files
Apache License 2.0
67 stars 36 forks source link

Deployment fails on clusters with containerd when credentials are empty #487

Closed alex-slynko closed 5 years ago

alex-slynko commented 5 years ago

This line does not work when we don't need credentials for Docker hub https://github.com/cloudfoundry-incubator/fissile/blob/c617cf6372fe75ebe255f2920c1dff6d6d0059ba/kube/registry_credentials.go#L23 Deployment fails. See more in slack thread https://cloudfoundry.slack.com/archives/C8RU3BZ26/p1551369471021700

alex-slynko commented 5 years ago

cc @cloudfoundry-incubator/eirini

gdankov commented 5 years ago

Any news on this?

jandubois commented 5 years ago

@gdankov: I've created a PR so that imagePullSecrets aren't generated when the username is empty:

      {{- if ne .Values.kube.registry.username "" }}
      imagePullSecrets:
      - name: "registry-credentials"
      {{- end }}

The same condition is also put around the whole contents of registry-secret.yaml.

You can can point the SCF build to the checks/fissile-7.0.0+297.g2485f273.linux-amd64.tgz CI build by changing the fissile flavour and version at https://github.com/SUSE/scf/blob/develop/bin/common/versions.sh#L12-L13.

Please let us know if this fixes the problem for you!

jandubois commented 5 years ago

@gdankov @alex-slynko

Please let us know if this fixes the problem for you!

There merging of this PR is currently blocked on getting confirmation that the change fixes the issue; so please report back as soon as you know!

jandubois commented 5 years ago

@gdankov @alex-slynko

Any news on this?

akshaymankar commented 5 years ago

Hey @jandubois, I am from the eirini team and am working on the story now. I am happy to report that the PR is working as expected. Thanks for the fix!