Don't generate imagePullSecrets when the username is empty

cloudfoundry-incubator / fissile

Turn a BOSH release into container images / files

Apache License 2.0

67 stars 36 forks source link

Closed jandubois closed 5 years ago

jandubois commented 5 years ago

Fixes #487.

The template only checks for an empty username, so the same logic should apply to a private registry that doesn't require authentication.

cfdreddbot commented 5 years ago

:white_check_mark: Hey jandubois! The commit authors and yourself have already signed the CLA.

jandubois commented 5 years ago

Approved pending trying to use this on various CRI backends.

Are you going to try on "various CRI backends" or do you expect somebody else to do this?

I would be fine merging this as soon as we have confirmation that it indeed fixes #487.

mook-as commented 5 years ago

Just going to wait for #487, yeah.