Extend feature-flag support to colocated containers

cloudfoundry-incubator / fissile

Turn a BOSH release into container images / files

Apache License 2.0

67 stars 36 forks source link

Extend feature-flag support to colocated containers #528

Closed tareqmamari closed 4 years ago

tareqmamari commented 4 years ago

There are situations where we need to enable/disable colocated containers through feature flags, as currently it is not fully supported, and hence this PR.

linux-foundation-easycla[bot] commented 4 years ago

The committers are authorized under a signed CLA.

:white_check_mark: Tareq Al-Maamari (858d4aeeb6f3b33f216683ad41a85f7bb4ae8afb)

tareqmamari commented 4 years ago

Thanks @HeavyWombat for the review, @viovanov @mook-as @jandubois could you please have a look as well ?

jandubois commented 4 years ago

@tareqmamari Yes, will take a look later today

jandubois commented 4 years ago

@tareqmamari @HeavyWombat Please note that the current fissile develop requires an update to configgin-0.20. This has happened in the stemcells used by by develop in SCF, but if you use your own stemcells, you may need to bump configgin; otherwise deployment will hang.

PS: Just realized that I didn't push a 0.20.0 tag to the configgin repo when making the release to rubygems; will add the tag later today too.