search

cloudfoundry-incubator / kubecf

Cloud Foundry on Kubernetes
Apache License 2.0
115 stars 62 forks source link

fix: use images from Github Container Registry #1581

Closed jandubois closed 4 years ago

jandubois commented 4 years ago

This PR uses the images on ghcr.io built with the latest stemcell.

The following images still reside on Dockerhub:

docker.io/cfcontainerization/coredns

Ref #1557

jandubois commented 4 years ago

There are 2 images in a different org that probably should be moved to cloudfoundry-incubator:

ghcr.io/cfcontainerizationbot/kubecf-apps-dns
ghcr.io/cfcontainerizationbot/kubecf-kubectl
jandubois commented 4 years ago

I found the current postgres version does not exist for autoscaler. There are newer releases, so I tried this patch:

--- a/chart/config/releases.yaml
+++ b/chart/config/releases.yaml
@@ -53,7 +53,7 @@ releases:
     condition: false
   postgres:
     condition: features.autoscaler.enabled
-    version: "39"
+    version: "42"
   sync-integration-tests:
     # XXX SITS only makes sense when using Diego; add error check somewhere?
     condition: testing.sync_integration_tests.enabled

But then asdatabase-0 pod never got ready. This blocks init containers in other autoscaler pods, so I don't know what the status of the autoscaler images is.

mook-as commented 4 years ago

The autoscaler issue was a hard-coded version in a path in the readiness probe; pushed a commit to make that work. Also, bump the SITS version down since v0.0.3 doesn't seem to be on GHCR (will need to address that in a bit).

Current list (as given by imagelist.txt):

docker.io/cfcontainerization/pxc:0.9.11
splatform/eirinix-loggregator-bridge:v0.0.0-0.g7da9e04
splatform/eirinix-persi-broker-setup:v0.0.0-g9d08cc7
splatform/eirinix-persi-broker:v0.0.0-g0c241e7
splatform/eirinix-persi:v0.0.0-73.g8201eba
splatform/eirinix-ssh-proxy-setup:v0.0.0-g9d08cc7
splatform/eirinix-ssh:v0.0.0-0.g09b53c0
viccuad commented 4 years ago

Full KubeCF installations from this PR should now work. Ready for review.

Comitted the change for eirinix images, created from the updated eirinix Concourse pipeline from here https://github.com/cloudfoundry-incubator/eirinix/pull/58. Some images where missing from ghcr.io, as they predate the pipeline change on publishing, so I copied those tagged images manually to ghcr.io/cloudfoundry-incubator.

Tested by deploying diego, eirini, ha & autoscaler successfully.

Only missing image was docker.io/cfcontainerization/pxc:0.9.11, which I manually copied to ghcr.io/cloudfoundry-incubator/pxc:0.9.11 meanwhile we wait for resolution of https://github.com/SUSE/cloudfoundry/pull/201.

viccuad commented 4 years ago

Instead of opening a new PR for consuming the pxc image, I have edited the title and body of the PR and expanded the PR scope to all images, not only bosh-release images.

My intent was to have only 1 PR with all the new images, so it's easy to pass through CI.