feat: Use cflinuxfs3 as default stack

cloudfoundry-incubator / kubecf

Cloud Foundry on Kubernetes

Apache License 2.0

115 stars 62 forks source link

feat: Use cflinuxfs3 as default stack #1682

Closed thardeck closed 3 years ago

thardeck commented 3 years ago

to make sure the latest upstream buildpacks can be used by default.

linux-foundation-easycla[bot] commented 3 years ago

The committers are authorized under a signed CLA.

:white_check_mark: Tim Hardeck (b2d5efceaa7097bb09099adcbfc3d2c089bda6af)

thardeck commented 3 years ago

I suppose this will make Eirini fail with default install_stacks. On CI, we select the sle15 stack if deploying Eirini, so it should succeed there. Eirini seems to have separate configuration options which I did not change.

troytop commented 3 years ago

If the platform admin did not specify the stacks (and their order) in their values, upgrading to this version would change the default stack (IIUC). This would be an unexpected change for the end users and probably not be immediately noticed by the admin.

Better to leave the defaults as they are and make a release note to manually change the default stack in values.yaml. That way, admins know that the change is happening.

viccuad commented 3 years ago

@troytop thank you. I missed that in the review.

@viovanov ping, to include "Manually change default stack to cflinuxfs3" in release notes.