Containers are already terminating while drain scripts of other jobs in the instance group are still running

cloudfoundry-incubator / kubecf

Cloud Foundry on Kubernetes

Apache License 2.0

115 stars 62 forks source link

Containers are already terminating while drain scripts of other jobs in the instance group are still running #1706

Open jandubois opened 3 years ago

jandubois commented 3 years ago

This is a bug in quarks-operator: https://github.com/cloudfoundry-incubator/quarks-operator/issues/1297

Just creating a corresponding kubecf issue so we can track it for the 2.8.0 release milestone.

univ0298 commented 3 years ago

I know this is just a shadow defect so it's not that important.. but FWIW the title of this issue is a bit misleading. Individual containers do not terminate while their drain scripts are running. The problem is specifically that each individual container will terminate once it's own drain script ends (or immediately if it has no drain script). Instead each container in a pod should wait for all other containers in the pod to finish their drains before any container terminates.

jandubois commented 3 years ago

I've tried to improve it, but it is hard to fit the whole story into the subject line...

Anyways, this issue only exists so I could add it to the 2.8.0 Milestone.

univ0298 commented 3 years ago

looks good!