cloudfoundry-incubator / kubecf

Cloud Foundry on Kubernetes
Apache License 2.0
115 stars 62 forks source link

Eirini warm-up jobs for staging images #806

Open mudler opened 4 years ago

mudler commented 4 years ago

Is your feature request related to a problem? Please describe. During the push of the first-app with Eirini as Scheduler, the staging images are being pulled in runtime. This breaks also air-gapped environment, as we require network access during the first push.

This also causes intermittent smoke-test failures, as it can exceed the timeout of the app push and makes difficult to list the staging images as part of the imagelist used by the chart.

Describe the solution you'd like A warm-up job that pulls the images during deployment and deletes itself. In this way we also make the images part of the helm chart

Describe alternatives you've considered N/A

Additional context

https://github.com/cloudfoundry-incubator/kubecf/pull/603#issuecomment-607866358 https://github.com/cloudfoundry-incubator/kubecf/issues/672

andreas-kupries commented 4 years ago

Note #796

jandubois commented 4 years ago

I don't like the idea of a warmup job, which really would need to be a DaemonSet because the image has to be pulled onto each node. And even then you will need internet access again every time you add or reinstall a node.

It must be possible to determine a complete set of required images beforehand, and their location must be configurable, so they can be redirected to a local registry inside an air-gapped installation.