search

cloudfoundry-incubator / kubo-release

Kubernetes BOSH release
https://www.cloudfoundry.org/container-runtime/
Apache License 2.0
161 stars 76 forks source link

Use k8s-args.root-dir in drain script when watching for PVC detach #314

Closed tvs closed 5 years ago

tvs commented 5 years ago

What this PR does / why we need it: If root-dir gets set then PVCs are mounted in a different location than /var/lib/kubelet. The piece of drain script that monitors for PVCs to be fully detached during a drain needs the monitor the correct location.

How can this PR be verified? The spec test performs some verification. There is also an edge-case that we regularly hit on AWS where the EBS volume doesn't get fully detached during the Turbulence suite and it leads to the StatefulSet not restarting successfully. https://ci.kubo.sh/teams/main/pipelines/aws_vanilla_turbulence/jobs/run-tests/builds/36 is one such instance.

Is there any change in kubo-deployment? No.

Is there any change in kubo-ci? No.

Does this affect upgrade, or is there any migration required? No.

Which issue(s) this PR fixes: None.

cfdreddbot commented 5 years ago

:white_check_mark: Hey tvs! The commit authors and yourself have already signed the CLA.

tvs commented 5 years ago

@pgoodwin @imikushin - looks like we missed a piece with https://github.com/cloudfoundry-incubator/kubo-deployment/pull/384

altonf4 commented 5 years ago

LGTM