search

cloudfoundry-incubator / spiff

declarative BOSH deployment manifest builder
Apache License 2.0
64 stars 44 forks source link

Spiff is not honest when handle "" #77

Closed cdlliuy closed 8 years ago

cdlliuy commented 8 years ago

I have the following YAML file, in which I hardcoded some key value pair and enclose with "". Then after running spiff to replace some parts of the template.yml (didn't attach here, since the merge works great), I found the hardcoded key value pair format are changed. " -> ' or deleted ..

Could spiff be honest to keep the "" part if no merge required, just copy the original one directly to output

template.yml:

foo:
  json: "{key: value}"  
  non-json: "key: value"
$ spiff merge template.yml:

foo:
  non-json: key: value
  json: '{key: value}'
cf-gitbot commented 8 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/126841161

The labels on this github issue will be updated when the story is started.

Amit-PivotalLabs commented 8 years ago

Hi @cdlliuy

I'm not sure why the single quotes vs double quotes matter, but removing the quotes altogether definitely seems like a big, since it will lead to invalid YAML. That said, as noted in the README:

Active development on spiff is currently paused, including Pull Requests. Very severe issues will be addressed, and we will still be actively responding to requests for help via Issues.

As this issue doesn't appear to be severe, I will close this issue at this time.