search

cloudfoundry / bosh-alicloud-cpi-release

BOSH Alibaba CPI
Apache License 2.0
32 stars 20 forks source link

BoshEnv struct does not have Blobstores field in registry/agent_settings.go #132

Closed yatzek closed 3 years ago

yatzek commented 3 years ago

BoshEnv struct in registry/agent_settings.go is generally out of sync with bosh agent settings:

https://github.com/cloudfoundry/bosh-agent/blob/master/settings/settings.go#L276

The missing "Blobstores" field, in particular, is an issue with regard to signed blobstore urls feature. Blobstore details from bosh env are not passed to IaaS registry user-data and this results in a broken bosh agent configuration.

The issue we are seeing is that the bosh agent tries to fetch blobs from a blobstore using signed urls (https) without a blobstore ca certificate:

Get "https://10.0.3.11:25250/signed/ba/cc5de529-b202-47c9-576a-4747d217e649?e=86400&st=xzH6ojhFStSiN2P7GSgljCrA3eGyMuDNjoBZZ_1_hxQ&ts=1623772918": x509: certificate signed by unknown authority
StefanWutz commented 3 years ago

@xiaozhu36: What is your opinion on that?

yatzek commented 3 years ago

@xiaozhu36: Would it make sense to keep agent Env settings generic like in the GCP cpi: https://github.com/cloudfoundry/bosh-google-cpi-release/blob/a0893932f636403e5524f8d5f4055257a75e2637/src/bosh-google-cpi/registry/agent_settings.go#L71 ?

This way, when new fields are added in the future, it will just come through.

yatzek commented 3 years ago

@xiaozhu36: are you guys planning a new release any time soon?

xiaozhu36 commented 3 years ago

Hi @yatzek The release 39.0.0 has been published. Please have a check.