cloudfoundry / bosh-alicloud-cpi-release

BOSH Alibaba CPI
Apache License 2.0
32 stars 20 forks source link

Add NTP field to BoshEnv struct #152

Closed friegger closed 2 years ago

friegger commented 2 years ago

Similar to #133, the NTP field is missing. The missing field causes the recommended way to configure NTP as described in https://bosh.io/docs/ntp-config/#configuring-ntp-servers-in-the-director-itself to fail.

Btw the Google CPI seems to handle this generically: https://github.com/cloudfoundry/bosh-google-cpi-release/blob/f31024b544458c9032162834d91801b2eb3da1a6/src/bosh-google-cpi/registry/agent_settings.go#L71

linux-foundation-easycla[bot] commented 2 years ago

CLA Signed

The committers are authorized under a signed CLA.

friegger commented 2 years ago

@xiaozhu36 Can you please review?