cloudfoundry / bosh-aws-cpi-release

BOSH AWS CPI
Apache License 2.0
29 stars 62 forks source link

Add rexml as top level dependency #127

Closed schmidtsv closed 2 years ago

schmidtsv commented 2 years ago

During my tests for the GP3 throughput and iops PR #126 I had the issue that the CPI would emit errors on compile:

`set_default_engine': Unable to find a compatible xml library. Ensure that you have installed or added to your Gemfile one of ox, oga, libxml, nokogiri or rexml (RuntimeError)

I checked the Gemfile and Gemfile.lock and saw rexml was not being vendored, as the only Gem requiring it was crack, which in turn was required by webmock. This caused no xml runtime to be present.

Why this worked in the past or currently on release building, I do not know, but adding the Gem to the Gemfile made it so dev releases were able to compile and run on a BOSH director.