search

cloudfoundry / bosh-azure-storage-cli

Go CLI for Azure storage
Apache License 2.0
0 stars 5 forks source link

Initial azure-storage-cli version #1

Closed mvach closed 1 year ago

mvach commented 1 year ago

The azure storage cli is required to solve https://github.com/cloudfoundry/bosh-azure-cpi-release/issues/672. It still need to be integrated into the director and the agent.

rkoster commented 1 year ago

@jpalermo & @ragaskar do y'all have time to review this PR?

ragaskar commented 1 year ago

I was also able to compile it and run through all the commands in the README you created (thank you!)

A couple notes:

Uploading a blob:

curl -X GET 


should be

Uploading a blob:

curl -X PUT -H "x-ms-blob-type: blockblob" -F ‘fileX=<path/to/file>’

Downloading a blob:

curl -X GET 


I found that the `curl` command provided for the PUT did not store my file as I expected but just dumped form-data when I took it literally,. eg, when I set -F `fileX=./test.foo` I got:

--------------------------b44b6325ba33f6fc Content-Disposition: form-data; name="fileX"

./test.foo --------------------------b44b6325ba33f6fc--



(i.e., used `fileX=`... not sure what I might have done wrong, but might be worth reviewing that snippet for typos). 

But no reason not to merge! Thanks for your patience.
mvach commented 1 year ago

Hi @ragaskar, PR https://github.com/cloudfoundry/bosh-azure-storage-cli/pull/2 is addressing your feedback. THX!