search

cloudfoundry / bosh-bootloader

Command line utility for standing up a BOSH director on an IAAS of your choice.
Apache License 2.0
178 stars 180 forks source link

ci: Fix ops files for deploy-cf task #569

Closed ystros closed 1 year ago

ystros commented 1 year ago

The cf-deployment-concourse-tasks/bosh-deploy/task.yml task expects that the OPS_FILES variable is formatted as a list of space-separated file names.

See: https://github.com/cloudfoundry/cf-deployment-concourse-tasks/blob/03f785df60c5d851ee47aee4967b06fa7327d8e2/shared-functions#L122-L125

Configuring it as a YAML array of file names led to the following error when it tries to build up the -o options for bosh:

invalid argument for flag `-o, --ops-file' (expected []opts.OpsFileArg):
Reading ops file
'ops-files/["operations/use-compiled-releases.yml","operations/experimental/fast-deploy-with-downtime-and-danger.yml"]':
Opening file
ops-files/["operations/use-compiled-releases.yml","operations/experimental/fast-deploy-with-downtime-and-danger.yml"]:
open
ops-files/["operations/use-compiled-releases.yml","operations/experimental/fast-deploy-with-downtime-and-danger.yml"]:
no such file or directory
ystros commented 1 year ago

I've already re-configured the pipeline with this change to get the job green, this commit is so that we don't lose the change. It seems less risky to modify how we pass OPS_FILES here than how the cf-deployment-concourse-tasks repo expects it to be formatted (which I assume is in use by other pipelines)