search

cloudfoundry / bosh-cli

BOSH CLI v2+
Apache License 2.0
178 stars 161 forks source link

`bosh create release` should take `private.yml` credentials as arguments #22

Closed DanielJonesEB closed 3 years ago

DanielJonesEB commented 7 years ago

Could we please provide private.yml credentials as arguments to bosh create release? This would make providing credentials via CI (ie Concourse) much easier, as we don't need to template a file.

cppforlife commented 7 years ago

@DanielJonesEB what do you think about specifying path to private.yml via cli flag. then you could do --private <(something here). or do you think private.yml should remain in the repo and just work with -l flag to interpolate variables?

cc @vito

DanielJonesEB commented 7 years ago

Thanks for taking the time to consider this, @cppforlife.

There are only three supported blobstore types at present, is that correct? Atmos, S3 and Local? If so, I think the user experience would be nicest if there was the option to specify the relevant values purely by command line --blobstore-type s3 --access-key foo --secret-key bar, although I can see that leads to three branches of 'special case' code.

Failing that, the variable interpolation would be cool. I'm not familiar with the -l flag: is that something new?

cppforlife commented 7 years ago

we are planning to add --private-conf flag that can be used with bash's standard pipe redirect:

$ bosh create-release --final --private-conf <(lpass ... or may be bosh build-manifest ... -l ...)
bonzofenix commented 7 years ago

@cppforlife is Atmos still supported in bosh cli V2?

tylerschultz commented 7 years ago

@bonzofenix s3 and local are the currently supported types: https://github.com/cloudfoundry/bosh-cli/blob/bb528b8072d38785e29cd1e5d19cdb53a4b46409/releasedir/provider.go#L101-L108

cc @cppforlife

freddesbiens commented 5 years ago

Hi @DanielJonesEB!

I simply want to check with you if this issue is still relevant to you. If that's still the case, I will have a deeper discussion on it with the engineering team. Please let me know.

DanielJonesEB commented 5 years ago

Thanks for following up! It's not causing any acute pain at the moment.

bosh-admin-bot commented 3 years ago

This issue was marked as Stale because it has been open for 21 days without any activity. If no activity takes place in the coming 7 days it will automatically be close. To prevent this from happening remove the Stale label or comment below.

bosh-admin-bot commented 3 years ago

This issue was closed because it has been labeled Stale for 7 days without subsequent activity. Feel free to re-open this issue at any time by commenting below.