cloudfoundry / bosh-cli

BOSH CLI v2+
Apache License 2.0
178 stars 162 forks source link

Avoid `gopacket/pcap` import to ease builds #635

Closed jpalermo closed 11 months ago

jpalermo commented 11 months ago

We want to avoid importing gopacket/pcap; it forces CGO_ENABLED=1, which makes cross-compilation more challenging, which makes publishing binaries more difficult.

fixes, when running bin/build:

vendor/github.com/gopacket/gopacket/pcap/pcap.go:30:22: undefined: pcapErrorNotActivated

fixes, when running acceptance tests:

../vendor/github.com/gopacket/gopacket/pcap/pcap_unix.go:35:10: fatal error: 'pcap.h' file not found