search

cloudfoundry / bosh-deployment-resource

Apache License 2.0
12 stars 26 forks source link

Add note about releases overriding manifest versions #48

Closed molambo closed 6 years ago

molambo commented 6 years ago

We were pleasantly surprised to see that the releases we uploaded through this resource magically were overriding the version: latests we have in our manifest. We dug through the code to make sure we knew where this was happening, figured it'd be nice for future users if it was called out in the README.

cfdreddbot commented 6 years ago

Hey molambo!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

cfdreddbot commented 6 years ago

Hey molambo!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

drich10 commented 6 years ago

Thanks for improving the documentation around this! It was definitely a very intentional behavior of the resource so it is better to have it called out.