cloudfoundry / bosh-deployment

Collection of BOSH manifests referenced by cloudfoundry/docs-bosh
Apache License 2.0
135 stars 233 forks source link

Please Externalize NTP and DNS as variables #469

Open haydonryan opened 2 months ago

haydonryan commented 2 months ago

Most enterprises don't use google dns, and they'll use their own. Homelabs are in the same boat.

Removing the ops file (https://github.com/cloudfoundry/bosh-deployment/blob/master/local-dns.yml) removes the ability to replace the DNS.

https://github.com/cloudfoundry/bosh-deployment/blob/master/bosh.yml#L139 https://github.com/cloudfoundry/bosh-deployment/blob/master/bosh.yml#L45-L48 https://github.com/cloudfoundry/bosh-deployment/blob/master/bosh.yml#L164-L167

haydonryan commented 2 months ago

Also the refernce on

local-dns.yml: Enables Director DNS beta functionality

https://github.com/cloudfoundry/bosh-deployment/tree/master?tab=readme-ov-file refers to an empty opsfile.

jpalermo commented 1 month ago

The local-dns ops file never allowed override of dns servers. It was used to enable the local_dns feature of bosh. You can see the old version of it here

There is an existing ops-file to replace the dns entries here: https://github.com/cloudfoundry/bosh-deployment/blob/master/misc/dns.yml

And the one to replace ntp values is here: https://github.com/cloudfoundry/bosh-deployment/blob/master/misc/ntp.yml

Typically empty ops-file are kept around when values are incorporated into defaults so people who have pipelines or tooling using those scripts don't see those things break as we make changes.

haydonryan commented 1 month ago

Ahh that makes sense on the local_dns and empty ops files.

I'm coming back from a hiatus to an implementation role. I assume PR for documentation updates is welcome?

beyhan commented 1 month ago

I assume PR for documentation updates is welcome?

yes, this is very welcome :-)

haydonryan commented 1 month ago

Awesome :)

haydonryan commented 1 month ago

Reopening to attach to PR