search

cloudfoundry / bosh-dns-release

BOSH DNS release
Apache License 2.0
18 stars 36 forks source link

Add a checkinternaldomain to the upcheck to validate internal domains #56

Closed andrew-edgar closed 4 years ago

andrew-edgar commented 4 years ago

This is to add validation to both upcheck domain and a bosh defined internal domain.

I would appreciate any assistance to this PR to see if there are additional tests to be implemented and how. As there seems to be lots that might be effected including performance and integration tests.

Let me know how you want to proceed.

cf-gitbot commented 4 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/171843080

The labels on this github issue will be updated when the story is started.

beyhan commented 4 years ago

I think that this will be an useful addition to bosh-dns and would like to help with this pull-request. I created a new pr https://github.com/cloudfoundry/bosh-dns-release/pull/59, where I tried to apply the suggestions provided by @xtreme-conor-nosal. @andrew-edgar I created the pull-request in the bosh-deps-forks organisation. I hope you have rights to push changes there.

aashah commented 4 years ago

We merged in #59 which overlaps a lot with the intent behind your PR @andrew-edgar. Could you take a look and see if that's true?

I'm going to close this PR out for now, but let's continue the discussion if there's something we're missing!

andrew-edgar commented 4 years ago

yeah sounds good thanks