Add metrics to bosh-dns

cloudfoundry / bosh-dns-release

BOSH DNS release

Apache License 2.0

18 stars 36 forks source link

Add metrics to bosh-dns #57

Closed beyhan closed 4 years ago

beyhan commented 4 years ago

metrics are collected only if they are enabled
metrics are collected for internal and external dns requests
coreDNS metrics plugin is used to collect metrics for all dns request done by bosh-dns.
there is configuration to enable metrics collection
they are exported locally only

cf-gitbot commented 4 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/172244284

The labels on this github issue will be updated when the story is started.

beyhan commented 4 years ago

It's also possible to have metrics for cached requests. The CoreDNS cache plugin collects metrics, but there is additional work needed to activate the metrics of of the cache plugin.

beyhan commented 4 years ago

@xtreme-conor-nosal thanks for the review. I have updated the pr.

cjnosal commented 4 years ago

Validated on linux with

dig @169.254.0.2 q-s4.group.network.deployment.bosh
curl 127.0.0.1:53088/metrics

and windows with

Resolve-DnsName -Name q-s4.group.network.deployment.bosh -Server $VM_IP
Invoke-RestMethod -Uri 127.0.0.1:53088/metrics

Thanks @beyhan