cloudfoundry / bosh-dns-release

BOSH DNS release
Apache License 2.0
18 stars 36 forks source link

Fix metrics reporting to also report return codes correctly. #67

Closed c0d1ngm0nk3y closed 3 years ago

c0d1ngm0nk3y commented 3 years ago

The return codes were always reported as NOERROR because the was no handler called inside the metrics handler where the return code could be recorded.

So instead of calling all handlers in serial (metrics, cache, forward), the metrics handler calls the next handler during reporting (metrics[cache, forward]).

This only applies if reporting metrics is enabled.

cf-gitbot commented 3 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/174944494

The labels on this github issue will be updated when the story is started.

beyhan commented 3 years ago

@mrosecrance will be nice if we can bring this in. This change doesn't effect the bosh-dns functionality. It has only an effect when metrics are enabled. We want to enable bosh-dns metrics ASAP on our landscapes, because we found them very useful.

beyhan commented 3 years ago

Thanks for looking into this and merging!