cloudfoundry / bosh-google-cpi-release

BOSH Google CPI
Apache License 2.0
63 stars 96 forks source link

Local ssd #309

Closed stigtermichiel closed 4 years ago

stigtermichiel commented 5 years ago

Hi there,

referencing issue #152

This is a first draft for a pull request implementing support for local ssd's. Currently only supports adding one ssd with the fixed size (I have no clue how attaching multiple ssd's would work). I can't get the integration tests to work, but I created a local release and tested it succesfully. Altough we needed this pull request: cloudfoundry/garden-runc-release#129 to be solved.

Only supports nvme for now, but it should be easy to support scsi as well.

Hopefully, third time lucky regarding the cla..

cfdreddbot commented 5 years ago

:white_check_mark: Hey stigtermichiel! The commit authors and yourself have already signed the CLA.

gerhard commented 5 years ago

I was just looking for this feature. Are you still interested in seeing it through @stigtermichiel ?

simonjohansson commented 4 years ago

@gerhard yeah, we have run this in production since the PR was submitted without any issues :)

gerhard commented 4 years ago

Thanks @simonjohansson!

@dpb587 is this on your radar? cc @tysen @evandbrown

stigtermichiel commented 4 years ago

Sorry @gerhard, totally missed your message!

simonjohansson commented 4 years ago

@evandbrown @jfmyers9 ping pong

simonjohansson commented 4 years ago

Monthly ping

mrosecrance commented 4 years ago

We're going to take a deeper look a this in the next month or so, but there's a few things that can be done first.

Why are there so many docs changes baked into this PR? This repo isn't a good place to keep things like docs on deploying CF - they're maintained elsewhere and some of these docs already have stale references to things like trusty. It also looks like some of the docs are not at all gcp specific. At the very least the docs changes should be pulled into a separate PR.

Also can you resolve the conflicts?

linux-foundation-easycla[bot] commented 4 years ago

CLA Check
The committers are authorized under a signed CLA.

stigtermichiel commented 4 years ago

My apologies, that must have happened when I tried to merge the develop branch in my branch. I will cherrypick the commits.

rkoster commented 4 years ago

@stigtermichiel Thanks!