search

cloudfoundry / bosh-google-cpi-release

BOSH Google CPI
Apache License 2.0
63 stars 96 forks source link

Make agent credentials optional for accessing blobstore with signed URLs enabled #327

Closed bgandon closed 3 years ago

bgandon commented 3 years ago

When signed URLs are enabled, no agent user/password should be specified in Director's deployment manifest for CPIs config.

This PR relates to previous work in:

Here we make the properties blobstore.agent.{user,password} optional.

Worth to note, since cloudfoundry/bosh-agent@b4ae2397 shipped in Agent v2.42.0 on November 2017, the blobstore.options (at the root of the Agent settings JSON) are not used anymore by the Bosh Agent. So nowadays that no more supported Stemcell ships with older Agents, the CPIs should not add those properties anymore to the Agent settings.

ERB unit tests have been added to provide proper coverage for the new use-case. Then can be run with:

./scripts/test-unit-erb

Co-Authored-By: @OliverMautschke

rkoster commented 3 years ago

Thanks, @bgandon LGTM