Redact more secrets from logs - Githubissues

cloudfoundry / bosh-google-cpi-release

BOSH Google CPI

Apache License 2.0

63 stars 96 forks source link

Redact more secrets from logs #343

Closed selzoc closed 1 year ago

selzoc commented 1 year ago

After the work completed in https://github.com/cloudfoundry/bosh-google-cpi-release/pull/342, we found that there were still spots in the logs where secrets were printed:

Updating VM metadata
Printing request bytes in the response logging

This commit:

extracts the redaction logic so it can be used in both places
expands the redaction regex to handle arbitrary json escaping
redacts in every conceivable logger call that could be logging secrets.