cloudfoundry / bosh-linux-stemcell-builder

BOSH Ubuntu Linux stemcells
Apache License 2.0
41 stars 103 forks source link

fix: don't change the systemd default from shared #311

Closed ae-govau closed 8 months ago

ae-govau commented 8 months ago

If the default is private, then if namespaced services (like auditd/chronyd) are restarted after the persistent disk is mounted, then it is not possible to fully unmount that disk until those services are stopped. The system will appear to let you do so, however the device remains busy and subsequent attempts to remount (as read-only) will fail as the device is busy.

Fixes #310

There's probably a test that could be written to confirm it this is not added, however I don't know the DSL that Ruby is using for that and probably won't pick up for this one change.

linux-foundation-easycla[bot] commented 8 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

ae-govau commented 8 months ago

CLA

This is a trivial change, and getting an authorized person to sign a CLA on my side will likely be onerous. Can this please be accepted as trivial and not requiring a CLA, or can a maintainer kindly reimplement the relevant deletion?

jpalermo commented 8 months ago

CLA is unfortunately required and I don't think there is much flexibility on that. Could you do this in your "free time" and sign the CLA just as yourself?

Bionic is also not built from the jammy branch, so the bionic guard shouldn't be needed.

ae-govau commented 8 months ago

Have updated the PR to drop the bionic guard, and it's now a delete only PR.

ae-govau commented 8 months ago

CLA is now signed.

ramonskie commented 8 months ago

@jpalermo would it be a good idea to let the garden team look at it as well. as they probably have more test scenarios

beyhan commented 8 months ago

@ae-govau Thanks for the contribution!

bgandon commented 8 months ago

Just a quick testimony: with the Stemcell v1.351 that ships this PR, the blocking issues I had with Concourse on Bosh-Lite seems to be fixed.

Thank you all 👏