Previously, the terraform-cpi resource was first copied to
terraform-cpi-deploy, then copied to terraform-bats. However, several
tasks including the Director cleanup task relied on terraform-bats being
present. So if the bats-ubuntu-manual job failed before a certain point,
the corresponding terraform destroy would fail because terraform-bats
resource wasn't present.
This also changes the export_terraform_variable helper function to
explicitly take the terraform metadata file as an argument, instead of
relying on a global metadata variable being defined.
This PR also deletes 2 dynamic network tasks that have not been in use since before 2021.
Previously, the terraform-cpi resource was first copied to terraform-cpi-deploy, then copied to terraform-bats. However, several tasks including the Director cleanup task relied on terraform-bats being present. So if the bats-ubuntu-manual job failed before a certain point, the corresponding terraform destroy would fail because terraform-bats resource wasn't present.
This also changes the export_terraform_variable helper function to explicitly take the terraform metadata file as an argument, instead of relying on a global
metadatavariable being defined.This PR also deletes 2 dynamic network tasks that have not been in use since before 2021.